Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OZ upgradeability filename #177

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

bap2pecs
Copy link
Contributor

when using a local geth, the default chain ID is 1337. So the Manifest file is named unknown-1337.json instead of unknown-31337.json

so rm -f .openzeppelin/unknown-31337.json doesn't work.

@cla-bot cla-bot bot added the cla-signed label Jan 21, 2024
@invocamanman
Copy link
Collaborator

I have some PRs pending, where the new contracts of the V2 is updated, could you done this PR once merged onto develop?¿ ^^
And thank you ^^!

@bap2pecs
Copy link
Contributor Author

@invocamanman for sure, lmk when it's merged

@invocamanman
Copy link
Collaborator

now is good to go hehe ^^

@bap2pecs bap2pecs changed the base branch from main to develop January 29, 2024 20:55
@bap2pecs
Copy link
Contributor Author

@invocamanman alright. I just changed base branch to develop

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

12 Security Hotspots
20.7% Duplication on New Code (required ≤ 20%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@invocamanman invocamanman merged commit e175a91 into 0xPolygonHermez:develop Jan 30, 2024
2 of 4 checks passed
@invocamanman
Copy link
Collaborator

Thank yoou!!!

@bap2pecs bap2pecs deleted the patch-4 branch January 30, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants